kerneltime commented on PR #46: URL: https://github.com/apache/ozone-docker-runner/pull/46#issuecomment-2795239155
> > Thanks @ChenSammi for the patch. > > I wonder if we should add the library in `ozone` image instead of `ozone-runner`. Hadoop version will probably depend on Ozone version. On the other hand, adding to the `ozone` image would prevent using it in acceptance tests with the runner image... > > @adoroszlai , thanks for the review. IIUC, ozone image is for user to try ozone, while ozone-runner is for ozone developer to run ozone locally with the local maven built package, also ozone-runner is used in CI acceptance test, right? So including the hadoop native library in ozone-runner, ozone image will inherit and have it too. But if including the hadoop native library in ozone image, then ozone-runner will not have this library. If all the above are true, then ozone-runner is the expected place. I had the same concern as @adoroszlai if we want the Docker runs picking up the maven build we should update the dist build to download this jar as a dependency and place it. Putting the hadoop jar into Ozone runtime should be done from the place we define the hadoop dependency which is the official Ozone repo. This image should have every thing else which is not defined by the Ozone dependencies. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For additional commands, e-mail: issues-h...@ozone.apache.org
