adoroszlai commented on code in PR #8252:
URL: https://github.com/apache/ozone/pull/8252#discussion_r2035068914
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/OzoneConfigKeys.java:
##########
@@ -339,8 +339,6 @@ public final class OzoneConfigKeys {
HDDS_CONTAINER_RATIS_NUM_WRITE_CHUNK_THREADS_PER_VOLUME_DEFAULT
= ScmConfigKeys.
HDDS_CONTAINER_RATIS_NUM_WRITE_CHUNK_THREADS_PER_VOLUME_DEFAULT;
- public static final String HDDS_CONTAINER_RATIS_REPLICATION_LEVEL_KEY
- = ScmConfigKeys.HDDS_CONTAINER_RATIS_REPLICATION_LEVEL_KEY;
public static final ReplicationLevel
HDDS_CONTAINER_RATIS_REPLICATION_LEVEL_DEFAULT
= ScmConfigKeys.HDDS_CONTAINER_RATIS_REPLICATION_LEVEL_DEFAULT;
Review Comment:
Same here.
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/ScmConfigKeys.java:
##########
@@ -54,8 +54,6 @@ public final class ScmConfigKeys {
public static final int
HDDS_CONTAINER_RATIS_NUM_WRITE_CHUNK_THREADS_PER_VOLUME_DEFAULT
= 10;
- public static final String HDDS_CONTAINER_RATIS_REPLICATION_LEVEL_KEY
- = "hdds.container.ratis.replication.level";
public static final ReplicationLevel
HDDS_CONTAINER_RATIS_REPLICATION_LEVEL_DEFAULT =
ReplicationLevel.MAJORITY;
Review Comment:
Please also remove the constant for the default value.
Import of `ReplicationLevel` also becomes unused and should be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org
