hemantk-12 commented on code in PR #8280:
URL: https://github.com/apache/ozone/pull/8280#discussion_r2043542048
##########
hadoop-ozone/cli-shell/src/main/java/org/apache/hadoop/ozone/shell/snapshot/SnapshotDiffHandler.java:
##########
@@ -156,7 +156,7 @@ private ObjectNode getJsonObject(SnapshotDiffReportOzone
diffReportOzone) {
.forEach(diffReportEntry ->
resArray.add(getJsonObject(diffReportEntry)));
diffReportNode.set("diffList", resArray);
- if (StringUtils.isNotEmpty(diffReportOzone.getToken())) {
+ if (diffReportOzone.getToken() != null) {
Review Comment:
This is fine. `StringUtils.isNotEmpty()` does the null and empty check.
I'll suggest using `StringUtils.isNotEmpty()` everywhere because empty token
is not a valid value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
