Gargi-jais11 commented on code in PR #8286:
URL: https://github.com/apache/ozone/pull/8286#discussion_r2044298114
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/DiskBalancerManager.java:
##########
@@ -120,7 +120,8 @@ public List<HddsProtos.DatanodeDiskBalancerInfoProto>
getDiskBalancerStatus(
.map(dn -> getInfoProto(dn, clientVersion))
.collect(Collectors.toList());
} else {
- return nodeManager.getAllNodes().stream()
+ return nodeManager.getNodes(IN_SERVICE,
+ HddsProtos.NodeState.HEALTHY).stream()
Review Comment:
If we consider stale datanode then for that also we need to show
diskbalancer status as UNKNOWN. But to be consistent with report command it is
better to show only healthy nodes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
