ChenSammi commented on code in PR #8239:
URL: https://github.com/apache/ozone/pull/8239#discussion_r2046347679
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/diskbalancer/DiskBalancerService.java:
##########
@@ -352,6 +359,10 @@ public BackgroundTaskQueue getTasks() {
}
if (queue.isEmpty()) {
+ bytesToMove = 0;
+ if (stopAfterDiskEven) {
+ setShouldRun(false);
Review Comment:
Please add a info log to tell that disk balancer is stopped due to disk even
and this property true.
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/diskbalancer/DiskBalancerService.java:
##########
@@ -463,18 +474,20 @@ public BackgroundTaskResult call() {
moveSucceeded = false;
if (diskBalancerTmpDir != null) {
try {
- Files.deleteIfExists(diskBalancerTmpDir);
+ File dir = new File(String.valueOf(diskBalancerTmpDir));
+ org.apache.commons.io.FileUtils.deleteDirectory(dir);
Review Comment:
Can you import this FileUtils?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
