adoroszlai commented on code in PR #7968:
URL: https://github.com/apache/ozone/pull/7968#discussion_r2049322687


##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/DatanodeConfiguration.java:
##########
@@ -627,142 +545,162 @@ public void setWaitOnAllFollowers(boolean val) {
   )
   private long deleteContainerTimeoutMs = Duration.ofSeconds(60).toMillis();
 
-  public long getDeleteContainerTimeoutMs() {
-    return deleteContainerTimeoutMs;
-  }
-
   @PostConstruct
   public void validate() {

Review Comment:
   ```
   
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/DatanodeConfiguration.java
    548: Method validate length is 159 lines (max allowed is 150).
   ```
   
   Can we defer improvements in `validate()` to a separate task?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org

Reply via email to