errose28 commented on code in PR #8248:
URL: https://github.com/apache/ozone/pull/8248#discussion_r2049745341


##########
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/debug/replicas/ReplicasVerify.java:
##########
@@ -54,6 +63,10 @@ public class ReplicasVerify extends Handler {
       required = true)
   private String outputDir;
 
+  @CommandLine.Option(names = {"--all"},

Review Comment:
   Seems it is probably better to have individual flags for checks, and to not 
make it run all checks by default to avoid surprises. For the `all` flags in 
the future we can use:
   - `--all-checks` in the future to indicate all verification types should be 
run.
   - `--all-results` to indicate that both passing and failing key results 
should be displayed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org

Reply via email to