[GitHub] [ozone] neils-dev opened a new pull request #2153: HDDS-5068. build errors due to missing JAXB-runtime jar dependency for openjdk 11 se standalone

Tue, 13 Apr 2021 17:15:55 -0700 


neils-dev opened a new pull request #2153:
URL: https://github.com/apache/ozone/pull/2153


   ## What changes were proposed in this pull request?
   
   Added maven build dependency _jaxb-runtime_ to each _pom.xml_ file in ozone 
build that requires _jaxb-api_ dependency.  Changes made to compile and run 
with Java 11 see 
_**https://javaee.github.io/jaxb-v2/doc/user-guide/ch03.html#deployment-maven-coordinates**_.
  In summary,
   `If client application needs to include the runtime, e.g. running standalone 
on JavaSE jaxb-runtime should be also included.
   `
   Fixes java 11 compile issues for unit testing ie. _hadoop-ozone/tools_ as 
well as ozone runtime commands such as _getconf_.
   
   Made small changes to fix unit test: 
_hadoop-hdds/container-service/TestContainerData.Yaml_.  With java 11 compile, 
unit test fails due to comparison between expected and actual container 
date/time.  Failure occurs because time in date/time is truncated (precision 
error) in comparison.  Change _to use_ timestamp epochs in milliseconds.
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/HDDS-5068
   
   ## How was this patch tested?
   
   Build without errors : 
   `mvn clean install -Phdds -DskipTests=true -Dmaven.javadoc.skip=true -Pdist 
-Dtar -DskipShade`
   and,
   `hadoop-ozone/dev-support/checks/unit.sh`
   with clean hadoop-hdds/container-service tests after patch for 
TestContainerDataYaml
   
   **Note:** observed _intermittent errors_ associated with  
_hdds-container-service_: _TestSchemaOneBackwardsCompatibility_ (problem due to 
thread-pool dispatching a non-blocking thread when testcase expects a blocking 
thread;  thread is not finished when test checks condition hence intermittent 
error).
    
   
![junit_test_fail_time_truncation_assert](https://user-images.githubusercontent.com/81126310/114636214-b1a59600-9c83-11eb-8d2e-81bf8c50f5b2.png)
   
   with fixed errors :
   
![junit_fix_pass_test](https://user-images.githubusercontent.com/81126310/114636219-b5d1b380-9c83-11eb-8547-b1dc41db47f5.png)
   
   
   **Also** tested with ozone getconf command (passes with patch, see jira for 
error reported by **@elek** ):
   
![ozone_getconf_command_with_patch](https://user-images.githubusercontent.com/81126310/114636392-25e03980-9c84-11eb-81ba-a668c0a2eee1.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to