errose28 commented on code in PR #8296:
URL: https://github.com/apache/ozone/pull/8296#discussion_r2053105887
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/ozoneimpl/OzoneContainer.java:
##########
@@ -432,7 +433,8 @@ private void
initOnDemandContainerScanner(ContainerScannerConfiguration c) {
"so the on-demand container data scanner will not start.");
return;
}
- OnDemandContainerDataScanner.init(c, controller);
+ onDemandScanner = new OnDemandContainerDataScanner(c, controller);
+ containerSet.registerContainerScanHandler(onDemandScanner::scanContainer);
Review Comment:
We could, but I would rather keep the coupling between the two classes
looser. We could make a scanner interface but it would only have one method and
only be used here. The consumer was a light-weight way to get this same
functionality.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
