Peter Lee created HDDS-12881:
--------------------------------

             Summary: Emits START_REPLICATION for ReplicationManager in 
SCMSafeModeManager#exitSafeMode
                 Key: HDDS-12881
                 URL: https://issues.apache.org/jira/browse/HDDS-12881
             Project: Apache Ozone
          Issue Type: Bug
            Reporter: Peter Lee
            Assignee: Peter Lee


Just notice that we the comment of SCMSafeModeManager#exitSafeMode says the 
safemode manager should tell the replicationManager that it can start to do the 
replication check. But I dont think we already have this.

[https://github.com/apache/ozone/pull/8311/files#diff-1ffe039aa52e2f283e868be3a0d68f09a3bd4c492b283333eb3f8a4b06f0fe51L220-L228]

 

I believe use the 
[ReplicationManagerEventHandler|https://github.com/apache/ozone/blob/master/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/ReplicationManagerEventHandler.java]
 introduced in [https://github.com/apache/ozone/pull/7997] to also listen to 
START_REPLICATION event is enough to have the same effect.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to