ivanzlenko commented on code in PR #8312:
URL: https://github.com/apache/ozone/pull/8312#discussion_r2054075085
##########
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/admin/nssummary/SummarySubCommand.java:
##########
@@ -52,14 +52,13 @@ public class SummarySubCommand implements Callable<Void> {
private static final String ENDPOINT = "/api/v1/namespace/summary";
- private StringBuffer url = new StringBuffer();
-
@Override
public Void call() throws Exception {
if (path == null || path.isEmpty()) {
printEmptyPathRequest();
return null;
}
+ StringBuffer url = new StringBuffer();
Review Comment:
Please replace StringBuffer with StringBuilder
##########
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/admin/nssummary/QuotaUsageSubCommand.java:
##########
@@ -53,14 +53,13 @@ public class QuotaUsageSubCommand implements Callable {
private static final String ENDPOINT = "/api/v1/namespace/quota";
- private StringBuffer url = new StringBuffer();
-
@Override
public Void call() throws Exception {
if (path == null || path.isEmpty()) {
printEmptyPathRequest();
return null;
}
+ StringBuffer url = new StringBuffer();
Review Comment:
Please replace StringBuffer with StringBuilder
##########
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/admin/nssummary/FileSizeDistSubCommand.java:
##########
@@ -52,14 +52,13 @@ public class FileSizeDistSubCommand implements Callable {
private static final String ENDPOINT = "/api/v1/namespace/dist";
- private StringBuffer url = new StringBuffer();
-
@Override
public Void call() throws Exception {
if (path == null || path.isEmpty()) {
printEmptyPathRequest();
return null;
}
+ StringBuffer url = new StringBuffer();
Review Comment:
Please replace StringBuffer with StringBuilder
##########
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/admin/nssummary/DiskUsageSubCommand.java:
##########
@@ -79,14 +79,13 @@ public class DiskUsageSubCommand implements Callable {
private static final int DU_INDENT = 12;
private static final int PATH_INDENT = 27;
- private StringBuffer url = new StringBuffer();
-
@Override
public Void call() throws Exception {
if (path == null || path.isEmpty()) {
printEmptyPathRequest();
return null;
}
+ StringBuffer url = new StringBuffer();
Review Comment:
Please replace StringBuffer with StringBuilder
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org
