jojochuang commented on code in PR #8276: URL: https://github.com/apache/ozone/pull/8276#discussion_r2055317914
########## hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmLCRule.java: ########## @@ -0,0 +1,291 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.ozone.om.helpers; + +import java.util.ArrayList; +import java.util.List; +import org.apache.commons.lang3.RandomStringUtils; +import org.apache.commons.lang3.StringUtils; +import org.apache.hadoop.ozone.om.exceptions.OMException; +import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos.LifecycleAction; +import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos.LifecycleRule; + +/** + * A class that encapsulates lifecycle rule. + */ +public class OmLCRule { + + public static final int LC_ID_LENGTH = 48; + // Ref: https://docs.aws.amazon.com/AmazonS3/latest/userguide/intro-lifecycle-rules.html#intro-lifecycle-rule-id + public static final int LC_ID_MAX_LENGTH = 255; + + private String id; + private String prefix; + private boolean enabled; + private boolean isPrefixEnable; + private boolean isTagEnable; + // List of actions for this rule + private List<OmLCAction> actions; + private OmLCFilter filter; + + OmLCRule(String id, String prefix, boolean enabled, + List<OmLCAction> actions, OmLCFilter filter) { + this.id = id; + this.prefix = prefix; + this.enabled = enabled; + this.actions = actions; + this.filter = filter; + + if (StringUtils.isEmpty(this.id)) { + this.id = RandomStringUtils.randomAlphanumeric(LC_ID_LENGTH); + } + + OmLifecycleRuleAndOperator andOperator = filter != null ? filter.getAndOperator() : null; + + if (prefix != null || + (filter != null && filter.getPrefix() != null) || + (andOperator != null && andOperator.getPrefix() != null)) { + isPrefixEnable = true; + } + + if ((filter != null && filter.getTag() != null) || + (andOperator != null && !andOperator.getTags().isEmpty())) { + isTagEnable = true; + } + } + + public String getId() { + return id; + } + + public void setId(String id) { + this.id = id; + } + + public String getPrefix() { + return prefix; + } + + public void setPrefix(String prefix) { + this.prefix = prefix; + } + + public boolean isEnabled() { + return enabled; + } + + public void setEnabled(boolean enabled) { + this.enabled = enabled; + } + + public List<OmLCAction> getActions() { + return actions; + } + + public void setActions(List<OmLCAction> actions) { + this.actions = actions; + } + + /** + * Get the expiration action if present. + * This method is for backward compatibility. + * + * @return the expiration action if present, null otherwise + */ + public OmLCExpiration getExpiration() { Review Comment: this method is used in the test code only. Why is it for backward compatibility? ########## hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmLCExpiration.java: ########## @@ -0,0 +1,161 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.ozone.om.helpers; + +import java.time.ZoneOffset; +import java.time.ZonedDateTime; +import java.time.format.DateTimeFormatter; +import java.time.format.DateTimeParseException; +import org.apache.hadoop.ozone.om.exceptions.OMException; +import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos.LifecycleAction; +import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos.LifecycleExpiration; + +/** + * A class that encapsulates lifecycle rule expiration action. + * This class extends OmLCAction and represents the expiration + * action type in lifecycle configuration. + */ +public class OmLCExpiration extends OmLCAction { + + private int days; + private String date; + + OmLCExpiration(int days, String date) { + this.days = days; + this.date = date; + } + + public int getDays() { + return days; + } + + public void setDays(int days) { + this.days = days; + } + + public String getDate() { + return date; + } + + public void setDate(String date) { + this.date = date; + } + + @Override + public ActionType getActionType() { + return ActionType.EXPIRATION; + } + + /** + * Validates the expiration configuration. + * - Days must be a positive number greater than zero + * - Either days or date should be specified, but not both or neither + * - The date value must conform to the ISO 8601 format + * - The date value must be in the future + * - The date value must be at midnight UTC (00:00:00Z) + * + * @throws OMException if the validation fails + */ + @Override + public void valid() throws OMException { Review Comment: this validation check can be refactored to make it cleaner. Right now the complexity makes corner case harder to spot. ########## hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmLCRule.java: ########## @@ -0,0 +1,291 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.ozone.om.helpers; + +import java.util.ArrayList; +import java.util.List; +import org.apache.commons.lang3.RandomStringUtils; +import org.apache.commons.lang3.StringUtils; +import org.apache.hadoop.ozone.om.exceptions.OMException; +import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos.LifecycleAction; +import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos.LifecycleRule; + +/** + * A class that encapsulates lifecycle rule. + */ +public class OmLCRule { + + public static final int LC_ID_LENGTH = 48; + // Ref: https://docs.aws.amazon.com/AmazonS3/latest/userguide/intro-lifecycle-rules.html#intro-lifecycle-rule-id + public static final int LC_ID_MAX_LENGTH = 255; + + private String id; + private String prefix; + private boolean enabled; + private boolean isPrefixEnable; + private boolean isTagEnable; + // List of actions for this rule + private List<OmLCAction> actions; + private OmLCFilter filter; + + OmLCRule(String id, String prefix, boolean enabled, + List<OmLCAction> actions, OmLCFilter filter) { + this.id = id; + this.prefix = prefix; + this.enabled = enabled; + this.actions = actions; + this.filter = filter; + + if (StringUtils.isEmpty(this.id)) { + this.id = RandomStringUtils.randomAlphanumeric(LC_ID_LENGTH); + } + + OmLifecycleRuleAndOperator andOperator = filter != null ? filter.getAndOperator() : null; + + if (prefix != null || + (filter != null && filter.getPrefix() != null) || + (andOperator != null && andOperator.getPrefix() != null)) { + isPrefixEnable = true; + } + + if ((filter != null && filter.getTag() != null) || + (andOperator != null && !andOperator.getTags().isEmpty())) { + isTagEnable = true; + } + } + + public String getId() { + return id; + } + + public void setId(String id) { + this.id = id; + } + + public String getPrefix() { + return prefix; + } + + public void setPrefix(String prefix) { + this.prefix = prefix; + } + + public boolean isEnabled() { + return enabled; + } + + public void setEnabled(boolean enabled) { + this.enabled = enabled; + } + + public List<OmLCAction> getActions() { + return actions; + } + + public void setActions(List<OmLCAction> actions) { + this.actions = actions; + } + + /** + * Get the expiration action if present. + * This method is for backward compatibility. + * + * @return the expiration action if present, null otherwise + */ + public OmLCExpiration getExpiration() { + if (actions == null || actions.isEmpty()) { + return null; + } + + for (OmLCAction action : actions) { + if (action instanceof OmLCExpiration) { + return (OmLCExpiration) action; + } + } + return null; Review Comment: Right now, null is not expected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For additional commands, e-mail: issues-h...@ozone.apache.org
