chungen0126 commented on code in PR #8297: URL: https://github.com/apache/ozone/pull/8297#discussion_r2055839892
########## hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/diskbalancer/DiskBalancerService.java: ########## @@ -346,8 +351,7 @@ public BackgroundTaskQueue getTasks() { inProgressContainers.add(toBalanceContainer.getContainerID()); deltaSizes.put(sourceVolume, deltaSizes.getOrDefault(sourceVolume, 0L) - toBalanceContainer.getBytesUsed()); - deltaSizes.put(destVolume, deltaSizes.getOrDefault(destVolume, 0L) Review Comment: Since we are still using `deltaSizes` to choose volume, why not just keep this. But also increase committed bytes to avoid over allocated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For additional commands, e-mail: issues-h...@ozone.apache.org