adoroszlai commented on code in PR #8292: URL: https://github.com/apache/ozone/pull/8292#discussion_r2063104686
########## hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/cli/AdminSubcommand.java: ########## Review Comment: My goal was to reduce change for this patch. These interfaces are currently in the `org/apache/hadoop/hdds/cli` directory, which does not exist in `cli-admin` and `ozone-tools`. We could create those, but then we'd need to add `package-info.java` in each. In the long run I would like to move those interfaces to better match the package hierarchy, ie. to `org/apache/hadoop/ozone/admin`, etc. But that requires changing imports in several files, which inflates the patch, so it's better to make it in a separate PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
