bshashikant commented on a change in pull request #2141:
URL: https://github.com/apache/ozone/pull/2141#discussion_r613177684
##########
File path:
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/scm/proxy/SCMBlockLocationFailoverProxyProvider.java
##########
@@ -250,7 +268,7 @@ public RetryPolicy getSCMBlockLocationRetryPolicy(String
newLeader) {
public RetryAction shouldRetry(Exception e, int retry,
int failover, boolean b) {
if (!SCMHAUtils.isRetriableWithNoFailoverException(e)) {
- performFailoverToAssignedLeader(newLeader);
+ performFailoverToAssignedLeader(newLeader, e);
Review comment:
> In performFailoverToAssignedLeader when newLeader is null, we still
failover to nextProxy. Eventough the exception type here is like
RETRIABLE_WITH_NO_FAILOVER_EXCEPTION_LIST
I think the failover will only happen if exception is not of type
SCMHAUtils.isRetriableWithNoFailoverException.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
