jojochuang commented on code in PR #8054:
URL: https://github.com/apache/ozone/pull/8054#discussion_r2072040325
##########
hadoop-ozone/interface-storage/src/main/java/org/apache/hadoop/ozone/om/OMMetadataManager.java:
##########
@@ -613,6 +613,11 @@ default String getOpenFileName(long volumeId, long
bucketId, long parentObjectId
*/
String getRenameKey(String volume, String bucket, long objectID);
+ /**
+ * Given renameKey, return the volume, bucket and objectID from the key.
+ */
+ String[] splitRenameKey(String renameKey);
Review Comment:
we're getting into the habit of creating helper methods inside
OMMetadataManager that are unrelated to OMMetadataManager internals. IMO it
(and others) should go into a utility class, like SnapshotUtil
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
