xiaoyuyao commented on a change in pull request #2144:
URL: https://github.com/apache/ozone/pull/2144#discussion_r613517468
##########
File path:
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestOzoneAtRestEncryption.java
##########
@@ -493,4 +493,11 @@ private static void assertReadContent(byte[] inputData,
byte[] readData,
offset + " and length " + readData.length,
inputDataForComparison, readData);
}
+
+ @Test
+ public void testGetKeyProvider() throws Exception {
+ KeyProvider kp1 = store.getKeyProvider();
+ KeyProvider kp2 = store.getKeyProvider();
+ Assert.assertEquals(kp1, kp2);
+ }
Review comment:
Good point. I had thought about it but the guava cache removal call back
is tricky to test initially. Spend some time today and figure out a way to use
mockito spy to test this indirectly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
