peterxcli commented on code in PR #6079:
URL: https://github.com/apache/ozone/pull/6079#discussion_r2072515629
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/TestHSync.java:
##########
@@ -226,6 +227,46 @@ public void testOfsHSync() throws Exception {
}
}
+ @Test
+ public void testHSyncDeletedKey() throws Exception {
+ // Verify that a key can't be successfully hsync'ed again after it's
deleted,
+ // and that key won't reappear after a failed hsync.
+
+ // Set the fs.defaultFS
+ final String rootPath = String.format("%s://%s/",
+ OZONE_OFS_URI_SCHEME, CONF.get(OZONE_OM_ADDRESS_KEY));
+ CONF.set(CommonConfigurationKeysPublic.FS_DEFAULT_NAME_KEY, rootPath);
+
+ final String dir = OZONE_ROOT + bucket.getVolumeName()
+ + OZONE_URI_DELIMITER + bucket.getName();
+ final Path key1 = new Path(dir, "key-hsync-del");
+
+ try (FileSystem fs = FileSystem.get(CONF)) {
+ // Create key1
+ try (FSDataOutputStream os = fs.create(key1, true)) {
+ os.write(1);
+ os.hsync();
+ fs.delete(key1, false);
+
+ // getFileStatus should throw FNFE because the key is deleted
+ assertThrows(FileNotFoundException.class,
+ () -> fs.getFileStatus(key1));
+ // hsync should throw because the open key is gone
+ try {
+ os.hsync();
Review Comment:
Observed from the test log when I was doing
https://github.com/apache/ozone/pull/7792,
the second `os.hsync` would be ignore with the
[logic](https://github.com/apache/ozone/pull/6054/files#diff-db8e4914806b73e8ec37c15ffd146fc70bd1fcba631df9a314c7389af64a895dR377-R383)
since there is not new write(`lastUpdatedBlockId == lastBLockId`).
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/TestHSync.java:
##########
@@ -226,6 +227,46 @@ public void testOfsHSync() throws Exception {
}
}
+ @Test
+ public void testHSyncDeletedKey() throws Exception {
+ // Verify that a key can't be successfully hsync'ed again after it's
deleted,
+ // and that key won't reappear after a failed hsync.
+
+ // Set the fs.defaultFS
+ final String rootPath = String.format("%s://%s/",
+ OZONE_OFS_URI_SCHEME, CONF.get(OZONE_OM_ADDRESS_KEY));
+ CONF.set(CommonConfigurationKeysPublic.FS_DEFAULT_NAME_KEY, rootPath);
+
+ final String dir = OZONE_ROOT + bucket.getVolumeName()
+ + OZONE_URI_DELIMITER + bucket.getName();
+ final Path key1 = new Path(dir, "key-hsync-del");
+
+ try (FileSystem fs = FileSystem.get(CONF)) {
+ // Create key1
+ try (FSDataOutputStream os = fs.create(key1, true)) {
+ os.write(1);
+ os.hsync();
+ fs.delete(key1, false);
+
+ // getFileStatus should throw FNFE because the key is deleted
+ assertThrows(FileNotFoundException.class,
+ () -> fs.getFileStatus(key1));
+ // hsync should throw because the open key is gone
+ try {
+ os.hsync();
Review Comment:
cc @jojochuang
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/TestHSync.java:
##########
@@ -226,6 +227,46 @@ public void testOfsHSync() throws Exception {
}
}
+ @Test
+ public void testHSyncDeletedKey() throws Exception {
+ // Verify that a key can't be successfully hsync'ed again after it's
deleted,
+ // and that key won't reappear after a failed hsync.
+
+ // Set the fs.defaultFS
+ final String rootPath = String.format("%s://%s/",
+ OZONE_OFS_URI_SCHEME, CONF.get(OZONE_OM_ADDRESS_KEY));
+ CONF.set(CommonConfigurationKeysPublic.FS_DEFAULT_NAME_KEY, rootPath);
+
+ final String dir = OZONE_ROOT + bucket.getVolumeName()
+ + OZONE_URI_DELIMITER + bucket.getName();
+ final Path key1 = new Path(dir, "key-hsync-del");
+
+ try (FileSystem fs = FileSystem.get(CONF)) {
+ // Create key1
+ try (FSDataOutputStream os = fs.create(key1, true)) {
+ os.write(1);
+ os.hsync();
+ fs.delete(key1, false);
+
+ // getFileStatus should throw FNFE because the key is deleted
+ assertThrows(FileNotFoundException.class,
+ () -> fs.getFileStatus(key1));
+ // hsync should throw because the open key is gone
+ try {
+ os.hsync();
Review Comment:
I don't think this would throw error as if there is not new block then the
second `hsync` call would be ignore.
reference:
https://github.com/apache/ozone/pull/6054/files#diff-db8e4914806b73e8ec37c15ffd146fc70bd1fcba631df9a314c7389af64a895dR377-R382
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
