swamirishi commented on code in PR #8054:
URL: https://github.com/apache/ozone/pull/8054#discussion_r2072588209
##########
hadoop-ozone/interface-storage/src/main/java/org/apache/hadoop/ozone/om/OMMetadataManager.java:
##########
@@ -613,6 +613,11 @@ default String getOpenFileName(long volumeId, long
bucketId, long parentObjectId
*/
String getRenameKey(String volume, String bucket, long objectID);
+ /**
+ * Given renameKey, return the volume, bucket and objectID from the key.
+ */
+ String[] splitRenameKey(String renameKey);
Review Comment:
@jojochuang I don't like the whole idea of Snapshots using MetadataManager
directly, right now all of our code is tightly coupled with metadatamanager.
Like other flows snapshots are supposed to use KeyManager & BucketManager etc.
These set of patches would cleanup these shortcomings in our implementation. I
@prashantpogde & @hemantk-12 had discussed this and aligned to eventually get
there. If we start using MetadataManager we are completely defeating the
purpose of higher level abstractions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org
