ArafatKhan2198 opened a new pull request, #8393: URL: https://github.com/apache/ozone/pull/8393
## What changes were proposed in this pull request? This PR fixes a failure in the layout feature finalization step of Recon upgrades. Specifically: - The upgrade actions previously used `ReconStorageContainerManagerFacade` to fetch the `DataSource`, but this added unnecessary coupling and complexity. - Now, the upgrade framework directly uses `DataSource`, simplifying the upgrade action interface. - During schema upgrades (e.g., adding columns in `ReconTaskStatusTableUpgradeAction`), we use `DSL.name()` for column references to avoid Derby-specific issues related to case sensitivity or delayed visibility of new columns. - Removed the older instantiation path of `ReconLayoutVersionManager` that relied on `SCMFacade`, and refactored related test cases accordingly. ## What is the link to the Apache JIRA https://issues.apache.org/jira/browse/HDDS-12968 ## How was this patch tested? - Verified on a running cluster that layout feature finalization works as expected after schema changes. - Confirmed that the new columns in `RECON_TASK_STATUS` are added and populated correctly. - Ran affected unit tests (`TestSchemaVersionTableDefinition`, `TestInitialConstraintUpgradeAction`, and `TestReconLayoutVersionManager`) which now use mock `DataSource` instead of `SCMFacade`. - Checked logs to ensure the layout upgrade flow logs feature versions and schema updates cleanly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
