adoroszlai commented on code in PR #8316:
URL: https://github.com/apache/ozone/pull/8316#discussion_r2074711966
##########
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/RandomKeyGenerator.java:
##########
@@ -168,6 +169,11 @@ enum FreonOps {
defaultValue = "1")
private int numOfValidateThreads = 1;
+ @Option(names = {"--validate-channel"},
+ description = "grpc or short-circuit.",
+ defaultValue = "grpc")
+ private String validateChannel = "grpc";
Review Comment:
Creating local `enum` in the CLI class (`RandomKeyGenerator` here) is a
small change and it allows picocli to validate the input for us.
https://picocli.info/#_enum_types
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
