[ 
https://issues.apache.org/jira/browse/HDDS-12854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17949618#comment-17949618
 ] 

Attila Doroszlai commented on HDDS-12854:
-----------------------------------------

Sorry, I missed one more that should not be removed:
- {{maven.test.redirectTestOutputToFile}}: 
https://maven.apache.org/surefire/maven-surefire-plugin/test-mojo.html#redirectTestOutputToFile

> Remove unused root pom.xml properties
> -------------------------------------
>
>                 Key: HDDS-12854
>                 URL: https://issues.apache.org/jira/browse/HDDS-12854
>             Project: Apache Ozone
>          Issue Type: Sub-task
>          Components: build
>    Affects Versions: 2.1.0
>            Reporter: Wei-Chiu Chuang
>            Assignee: Kiruthiga Prabakaran
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: locate_unused_maven_properties-1.py, 
> locate_unused_maven_properties.py
>
>
> I used ChatGPT to rewrite a script to identify unused Maven properties. Most 
> look legit. We should remove these properties.
> Here's the list:
> {noformat}
> % python3 locate_unused_maven_properties.py ozone ozone/pom.xml
> Parsing root pom.xml for defined properties...
> Found 188 properties in the root pom.xml.
> Searching for module pom.xml files in the project...
> Found 287 module pom.xml files.
> Result:
> The following properties are defined in the root pom.xml but are not used in 
> the root (outside of the properties block) or in any module pom.xml:
>  - declared.hadoop.version
>  - declared.hdds.version
>  - declared.ozone.version
>  - enforced.java.version
>  - enforced.maven.version
>  - failIfNoTests
>  - maven-surefire-report-plugin.version
>  - maven.test.redirectTestOutputToFile
>  - native.lib.tmp.dir
>  - ozone.release
>  - project.build.outputTimestamp
>  - project.reporting.outputEncoding
>  - sonar.java.binaries
>  - surefire.failIfNoSpecifiedTests
>  - swagger-annotations-version
> {noformat}
> Updated:
> {noformat}
> % python3 locate_unused_maven_properties.py ozone ozone/pom.xml
> Parsing root pom.xml properties…
> → 188 properties defined in root POM
> Locating module POMs…
> → 287 module pom.xml files found
> Locating resource .properties files…
> → 5 resource .properties files found
> Unused properties:
>  - declared.hadoop.version
>  - enforced.java.version
>  - enforced.maven.version
>  - failIfNoTests
>  - maven-surefire-report-plugin.version
>  - maven.test.redirectTestOutputToFile
>  - native.lib.tmp.dir
>  - project.build.outputTimestamp
>  - project.reporting.outputEncoding
>  - sonar.java.binaries
>  - surefire.failIfNoSpecifiedTests
>  - swagger-annotations-version
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to