jojochuang commented on code in PR #8392:
URL: https://github.com/apache/ozone/pull/8392#discussion_r2076632881
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotUtils.java:
##########
@@ -299,4 +300,55 @@ public static void validatePreviousSnapshotId(SnapshotInfo
snapshotInfo,
OMException.ResultCodes.INVALID_REQUEST);
}
}
+
+ public static boolean isBlockLocationInfoSame(OmKeyInfo prevKeyInfo,
Review Comment:
please add a javadoc explaining what it does.
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/service/SnapshotDeletingService.java:
##########
@@ -330,60 +328,6 @@ boolean shouldIgnoreSnapshot(SnapshotInfo snapInfo) throws
IOException {
!OmSnapshotManager.areSnapshotChangesFlushedToDB(getOzoneManager().getMetadataManager(),
snapInfo);
}
- // TODO: Move this util class.
Review Comment:
moved to SnapshotUtils
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/filter/ReclaimableKeyFilter.java:
##########
@@ -0,0 +1,161 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.ozone.om.snapshot.filter;
+
+import static
org.apache.hadoop.ozone.om.snapshot.SnapshotUtils.isBlockLocationInfoSame;
+
+import java.io.IOException;
+import java.util.HashMap;
+import java.util.Map;
+import java.util.Optional;
+import java.util.UUID;
+import org.apache.hadoop.hdds.utils.db.Table;
+import org.apache.hadoop.ozone.om.KeyManager;
+import org.apache.hadoop.ozone.om.OmSnapshot;
+import org.apache.hadoop.ozone.om.OmSnapshotManager;
+import org.apache.hadoop.ozone.om.OzoneManager;
+import org.apache.hadoop.ozone.om.SnapshotChainManager;
+import org.apache.hadoop.ozone.om.helpers.OmBucketInfo;
+import org.apache.hadoop.ozone.om.helpers.OmKeyInfo;
+import org.apache.hadoop.ozone.om.helpers.SnapshotInfo;
+import org.apache.hadoop.ozone.om.lock.IOzoneManagerLock;
+import org.apache.hadoop.ozone.om.snapshot.ReferenceCounted;
+import org.apache.ratis.util.MemoizedCheckedSupplier;
+import org.apache.ratis.util.function.CheckedSupplier;
+
+/**
+ * Filter to return deleted keys which are reclaimable based on their presence
in previous snapshot in
+ * the snapshot chain.
+ */
+public class ReclaimableKeyFilter extends ReclaimableFilter<OmKeyInfo> {
+ private final Map<UUID, Long> exclusiveSizeMap;
+ private final Map<UUID, Long> exclusiveReplicatedSizeMap;
+
+ /**
+ * @param currentSnapshotInfo : If null the deleted keys in AOS needs to be
processed, hence the latest snapshot
+ * in the snapshot chain corresponding to bucket
key needs to be processed.
+ * @param keyManager : keyManager corresponding to snapshot or AOS.
+ * @param lock : Lock for Active OM.
+ */
+ public ReclaimableKeyFilter(OzoneManager ozoneManager,
+ OmSnapshotManager omSnapshotManager,
SnapshotChainManager snapshotChainManager,
+ SnapshotInfo currentSnapshotInfo, KeyManager
keyManager,
+ IOzoneManagerLock lock) {
+ super(ozoneManager, omSnapshotManager, snapshotChainManager,
currentSnapshotInfo, keyManager, lock, 2);
+ this.exclusiveSizeMap = new HashMap<>();
+ this.exclusiveReplicatedSizeMap = new HashMap<>();
+ }
+
+ @Override
+ protected String getVolumeName(Table.KeyValue<String, OmKeyInfo> keyValue)
throws IOException {
+ return keyValue.getValue().getVolumeName();
+ }
+
+ @Override
+ protected String getBucketName(Table.KeyValue<String, OmKeyInfo> keyValue)
throws IOException {
+ return keyValue.getValue().getBucketName();
+ }
+
+ @Override
Review Comment:
```suggestion
/**
* Determines whether a deleted key entry is reclaimable by checking its
presence in prior snapshots.
*
* This method validates the existence of the deleted key in the previous
snapshot's key table or file table.
* If the key is not found in the previous snapshot, it is marked as
reclaimable. Otherwise, additional checks
* are performed using the previous-to-previous snapshot to confirm its
eligibility for reclamation.
*
* @param deletedKeyInfo The key-value pair representing the deleted key
information.
* @return {@code true} if the key is reclaimable (not present in prior
snapshots), {@code false} otherwise.
* @throws IOException If an error occurs while accessing snapshot data or
key information.
*/
@Override
```
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/filter/ReclaimableKeyFilter.java:
##########
@@ -0,0 +1,161 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.ozone.om.snapshot.filter;
+
+import static
org.apache.hadoop.ozone.om.snapshot.SnapshotUtils.isBlockLocationInfoSame;
+
+import java.io.IOException;
+import java.util.HashMap;
+import java.util.Map;
+import java.util.Optional;
+import java.util.UUID;
+import org.apache.hadoop.hdds.utils.db.Table;
+import org.apache.hadoop.ozone.om.KeyManager;
+import org.apache.hadoop.ozone.om.OmSnapshot;
+import org.apache.hadoop.ozone.om.OmSnapshotManager;
+import org.apache.hadoop.ozone.om.OzoneManager;
+import org.apache.hadoop.ozone.om.SnapshotChainManager;
+import org.apache.hadoop.ozone.om.helpers.OmBucketInfo;
+import org.apache.hadoop.ozone.om.helpers.OmKeyInfo;
+import org.apache.hadoop.ozone.om.helpers.SnapshotInfo;
+import org.apache.hadoop.ozone.om.lock.IOzoneManagerLock;
+import org.apache.hadoop.ozone.om.snapshot.ReferenceCounted;
+import org.apache.ratis.util.MemoizedCheckedSupplier;
+import org.apache.ratis.util.function.CheckedSupplier;
+
+/**
+ * Filter to return deleted keys which are reclaimable based on their presence
in previous snapshot in
+ * the snapshot chain.
+ */
+public class ReclaimableKeyFilter extends ReclaimableFilter<OmKeyInfo> {
+ private final Map<UUID, Long> exclusiveSizeMap;
+ private final Map<UUID, Long> exclusiveReplicatedSizeMap;
+
+ /**
+ * @param currentSnapshotInfo : If null the deleted keys in AOS needs to be
processed, hence the latest snapshot
+ * in the snapshot chain corresponding to bucket
key needs to be processed.
+ * @param keyManager : keyManager corresponding to snapshot or AOS.
+ * @param lock : Lock for Active OM.
+ */
+ public ReclaimableKeyFilter(OzoneManager ozoneManager,
+ OmSnapshotManager omSnapshotManager,
SnapshotChainManager snapshotChainManager,
+ SnapshotInfo currentSnapshotInfo, KeyManager
keyManager,
+ IOzoneManagerLock lock) {
+ super(ozoneManager, omSnapshotManager, snapshotChainManager,
currentSnapshotInfo, keyManager, lock, 2);
+ this.exclusiveSizeMap = new HashMap<>();
+ this.exclusiveReplicatedSizeMap = new HashMap<>();
+ }
+
+ @Override
+ protected String getVolumeName(Table.KeyValue<String, OmKeyInfo> keyValue)
throws IOException {
+ return keyValue.getValue().getVolumeName();
+ }
+
+ @Override
+ protected String getBucketName(Table.KeyValue<String, OmKeyInfo> keyValue)
throws IOException {
+ return keyValue.getValue().getBucketName();
+ }
+
+ @Override
+ protected Boolean isReclaimable(Table.KeyValue<String, OmKeyInfo>
deletedKeyInfo) throws IOException {
+ ReferenceCounted<OmSnapshot> previousSnapshot = getPreviousOmSnapshot(1);
+
+
+ KeyManager previousKeyManager = Optional.ofNullable(previousSnapshot)
+ .map(i -> i.get().getKeyManager()).orElse(null);
+
+
+ // Getting keyInfo from prev snapshot's keyTable/fileTable
+ CheckedSupplier<Optional<OmKeyInfo>, IOException> previousKeyInfo =
+ MemoizedCheckedSupplier.valueOf(() ->
getPreviousSnapshotKey(getVolumeId(), getBucketInfo(),
+ deletedKeyInfo.getValue(), getKeyManager(), previousKeyManager));
+ // If file not present in previous snapshot then it won't be present in
previous to previous snapshot either.
+ if (!previousKeyInfo.get().isPresent()) {
+ return true;
+ }
+
+ ReferenceCounted<OmSnapshot> previousToPreviousSnapshot =
getPreviousOmSnapshot(0);
+ KeyManager previousToPreviousKeyManager =
Optional.ofNullable(previousToPreviousSnapshot)
+ .map(i -> i.get().getKeyManager()).orElse(null);
+
+ // Getting keyInfo from prev to prev snapshot's keyTable/fileTable based
on keyInfo of prev keyTable
+ CheckedSupplier<Optional<OmKeyInfo>, IOException> previousPrevKeyInfo =
+ MemoizedCheckedSupplier.valueOf(() -> getPreviousSnapshotKey(
+ getVolumeId(), getBucketInfo(),
previousKeyInfo.get().orElse(null), previousKeyManager,
+ previousToPreviousKeyManager));
+ SnapshotInfo previousSnapshotInfo = getPreviousSnapshotInfo(1);
+ calculateExclusiveSize(previousSnapshotInfo, previousKeyInfo,
previousPrevKeyInfo,
+ exclusiveSizeMap, exclusiveReplicatedSizeMap);
+ return false;
+ }
+
+ public Map<UUID, Long> getExclusiveSizeMap() {
+ return exclusiveSizeMap;
+ }
+
+ public Map<UUID, Long> getExclusiveReplicatedSizeMap() {
+ return exclusiveReplicatedSizeMap;
+ }
+
+ /**
+ * To calculate Exclusive Size for current snapshot, Check
+ * the next snapshot deletedTable if the deleted key is
+ * referenced in current snapshot and not referenced in the
+ * previous snapshot then that key is exclusive to the current
+ * snapshot. Here since we are only iterating through
+ * deletedTable we can check the previous and previous to
+ * previous snapshot to achieve the same.
+ * previousSnapshot - Snapshot for which exclusive size is
+ * getting calculating.
+ * currSnapshot - Snapshot's deletedTable is used to calculate
+ * previousSnapshot snapshot's exclusive size.
+ * previousToPrevSnapshot - Snapshot which is used to check
+ * if key is exclusive to previousSnapshot.
+ */
+ private void calculateExclusiveSize(SnapshotInfo previousSnapshotInfo,
+ CheckedSupplier<Optional<OmKeyInfo>,
IOException> keyInfoPrevSnapshot,
+ CheckedSupplier<Optional<OmKeyInfo>,
IOException> keyInfoPrevToPrevSnapshot,
+ Map<UUID, Long> exclusiveSizes,
Map<UUID, Long> exclusiveReplicatedSizes)
+ throws IOException {
+ if (keyInfoPrevSnapshot.get().isPresent() &&
!keyInfoPrevToPrevSnapshot.get().isPresent()) {
+ OmKeyInfo keyInfo = keyInfoPrevSnapshot.get().get();
+ exclusiveSizes.compute(previousSnapshotInfo.getSnapshotId(),
+ (k, v) -> (v == null ? 0 : v) + keyInfo.getDataSize());
+ exclusiveReplicatedSizes.compute(previousSnapshotInfo.getSnapshotId(),
+ (k, v) -> (v == null ? 0 : v) + keyInfo.getReplicatedSize());
+ }
+
+ }
+
+ private Optional<OmKeyInfo> getPreviousSnapshotKey(long volumeId,
OmBucketInfo bucketInfo,
Review Comment:
return the OmKeyInfo object in the previous snapshot.
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/filter/ReclaimableKeyFilter.java:
##########
@@ -0,0 +1,161 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.ozone.om.snapshot.filter;
+
+import static
org.apache.hadoop.ozone.om.snapshot.SnapshotUtils.isBlockLocationInfoSame;
+
+import java.io.IOException;
+import java.util.HashMap;
+import java.util.Map;
+import java.util.Optional;
+import java.util.UUID;
+import org.apache.hadoop.hdds.utils.db.Table;
+import org.apache.hadoop.ozone.om.KeyManager;
+import org.apache.hadoop.ozone.om.OmSnapshot;
+import org.apache.hadoop.ozone.om.OmSnapshotManager;
+import org.apache.hadoop.ozone.om.OzoneManager;
+import org.apache.hadoop.ozone.om.SnapshotChainManager;
+import org.apache.hadoop.ozone.om.helpers.OmBucketInfo;
+import org.apache.hadoop.ozone.om.helpers.OmKeyInfo;
+import org.apache.hadoop.ozone.om.helpers.SnapshotInfo;
+import org.apache.hadoop.ozone.om.lock.IOzoneManagerLock;
+import org.apache.hadoop.ozone.om.snapshot.ReferenceCounted;
+import org.apache.ratis.util.MemoizedCheckedSupplier;
+import org.apache.ratis.util.function.CheckedSupplier;
+
+/**
+ * Filter to return deleted keys which are reclaimable based on their presence
in previous snapshot in
+ * the snapshot chain.
+ */
+public class ReclaimableKeyFilter extends ReclaimableFilter<OmKeyInfo> {
+ private final Map<UUID, Long> exclusiveSizeMap;
+ private final Map<UUID, Long> exclusiveReplicatedSizeMap;
+
+ /**
+ * @param currentSnapshotInfo : If null the deleted keys in AOS needs to be
processed, hence the latest snapshot
+ * in the snapshot chain corresponding to bucket
key needs to be processed.
+ * @param keyManager : keyManager corresponding to snapshot or AOS.
+ * @param lock : Lock for Active OM.
+ */
+ public ReclaimableKeyFilter(OzoneManager ozoneManager,
+ OmSnapshotManager omSnapshotManager,
SnapshotChainManager snapshotChainManager,
+ SnapshotInfo currentSnapshotInfo, KeyManager
keyManager,
+ IOzoneManagerLock lock) {
+ super(ozoneManager, omSnapshotManager, snapshotChainManager,
currentSnapshotInfo, keyManager, lock, 2);
+ this.exclusiveSizeMap = new HashMap<>();
+ this.exclusiveReplicatedSizeMap = new HashMap<>();
+ }
+
+ @Override
+ protected String getVolumeName(Table.KeyValue<String, OmKeyInfo> keyValue)
throws IOException {
+ return keyValue.getValue().getVolumeName();
+ }
+
+ @Override
+ protected String getBucketName(Table.KeyValue<String, OmKeyInfo> keyValue)
throws IOException {
+ return keyValue.getValue().getBucketName();
+ }
+
+ @Override
+ protected Boolean isReclaimable(Table.KeyValue<String, OmKeyInfo>
deletedKeyInfo) throws IOException {
+ ReferenceCounted<OmSnapshot> previousSnapshot = getPreviousOmSnapshot(1);
+
+
+ KeyManager previousKeyManager = Optional.ofNullable(previousSnapshot)
+ .map(i -> i.get().getKeyManager()).orElse(null);
+
+
+ // Getting keyInfo from prev snapshot's keyTable/fileTable
+ CheckedSupplier<Optional<OmKeyInfo>, IOException> previousKeyInfo =
+ MemoizedCheckedSupplier.valueOf(() ->
getPreviousSnapshotKey(getVolumeId(), getBucketInfo(),
+ deletedKeyInfo.getValue(), getKeyManager(), previousKeyManager));
+ // If file not present in previous snapshot then it won't be present in
previous to previous snapshot either.
+ if (!previousKeyInfo.get().isPresent()) {
+ return true;
+ }
+
+ ReferenceCounted<OmSnapshot> previousToPreviousSnapshot =
getPreviousOmSnapshot(0);
+ KeyManager previousToPreviousKeyManager =
Optional.ofNullable(previousToPreviousSnapshot)
+ .map(i -> i.get().getKeyManager()).orElse(null);
+
+ // Getting keyInfo from prev to prev snapshot's keyTable/fileTable based
on keyInfo of prev keyTable
+ CheckedSupplier<Optional<OmKeyInfo>, IOException> previousPrevKeyInfo =
+ MemoizedCheckedSupplier.valueOf(() -> getPreviousSnapshotKey(
+ getVolumeId(), getBucketInfo(),
previousKeyInfo.get().orElse(null), previousKeyManager,
+ previousToPreviousKeyManager));
+ SnapshotInfo previousSnapshotInfo = getPreviousSnapshotInfo(1);
+ calculateExclusiveSize(previousSnapshotInfo, previousKeyInfo,
previousPrevKeyInfo,
+ exclusiveSizeMap, exclusiveReplicatedSizeMap);
+ return false;
+ }
+
+ public Map<UUID, Long> getExclusiveSizeMap() {
+ return exclusiveSizeMap;
+ }
+
+ public Map<UUID, Long> getExclusiveReplicatedSizeMap() {
+ return exclusiveReplicatedSizeMap;
+ }
+
+ /**
+ * To calculate Exclusive Size for current snapshot, Check
+ * the next snapshot deletedTable if the deleted key is
+ * referenced in current snapshot and not referenced in the
+ * previous snapshot then that key is exclusive to the current
+ * snapshot. Here since we are only iterating through
+ * deletedTable we can check the previous and previous to
+ * previous snapshot to achieve the same.
+ * previousSnapshot - Snapshot for which exclusive size is
+ * getting calculating.
+ * currSnapshot - Snapshot's deletedTable is used to calculate
+ * previousSnapshot snapshot's exclusive size.
+ * previousToPrevSnapshot - Snapshot which is used to check
+ * if key is exclusive to previousSnapshot.
+ */
+ private void calculateExclusiveSize(SnapshotInfo previousSnapshotInfo,
Review Comment:
if so, shall we add checks in the test to verify exclusive size is expected
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/filter/ReclaimableKeyFilter.java:
##########
@@ -0,0 +1,161 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.ozone.om.snapshot.filter;
+
+import static
org.apache.hadoop.ozone.om.snapshot.SnapshotUtils.isBlockLocationInfoSame;
+
+import java.io.IOException;
+import java.util.HashMap;
+import java.util.Map;
+import java.util.Optional;
+import java.util.UUID;
+import org.apache.hadoop.hdds.utils.db.Table;
+import org.apache.hadoop.ozone.om.KeyManager;
+import org.apache.hadoop.ozone.om.OmSnapshot;
+import org.apache.hadoop.ozone.om.OmSnapshotManager;
+import org.apache.hadoop.ozone.om.OzoneManager;
+import org.apache.hadoop.ozone.om.SnapshotChainManager;
+import org.apache.hadoop.ozone.om.helpers.OmBucketInfo;
+import org.apache.hadoop.ozone.om.helpers.OmKeyInfo;
+import org.apache.hadoop.ozone.om.helpers.SnapshotInfo;
+import org.apache.hadoop.ozone.om.lock.IOzoneManagerLock;
+import org.apache.hadoop.ozone.om.snapshot.ReferenceCounted;
+import org.apache.ratis.util.MemoizedCheckedSupplier;
+import org.apache.ratis.util.function.CheckedSupplier;
+
+/**
+ * Filter to return deleted keys which are reclaimable based on their presence
in previous snapshot in
+ * the snapshot chain.
+ */
+public class ReclaimableKeyFilter extends ReclaimableFilter<OmKeyInfo> {
+ private final Map<UUID, Long> exclusiveSizeMap;
+ private final Map<UUID, Long> exclusiveReplicatedSizeMap;
+
+ /**
+ * @param currentSnapshotInfo : If null the deleted keys in AOS needs to be
processed, hence the latest snapshot
+ * in the snapshot chain corresponding to bucket
key needs to be processed.
+ * @param keyManager : keyManager corresponding to snapshot or AOS.
+ * @param lock : Lock for Active OM.
+ */
+ public ReclaimableKeyFilter(OzoneManager ozoneManager,
+ OmSnapshotManager omSnapshotManager,
SnapshotChainManager snapshotChainManager,
+ SnapshotInfo currentSnapshotInfo, KeyManager
keyManager,
+ IOzoneManagerLock lock) {
+ super(ozoneManager, omSnapshotManager, snapshotChainManager,
currentSnapshotInfo, keyManager, lock, 2);
Review Comment:
why 2?
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/filter/ReclaimableKeyFilter.java:
##########
@@ -0,0 +1,161 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.ozone.om.snapshot.filter;
+
+import static
org.apache.hadoop.ozone.om.snapshot.SnapshotUtils.isBlockLocationInfoSame;
+
+import java.io.IOException;
+import java.util.HashMap;
+import java.util.Map;
+import java.util.Optional;
+import java.util.UUID;
+import org.apache.hadoop.hdds.utils.db.Table;
+import org.apache.hadoop.ozone.om.KeyManager;
+import org.apache.hadoop.ozone.om.OmSnapshot;
+import org.apache.hadoop.ozone.om.OmSnapshotManager;
+import org.apache.hadoop.ozone.om.OzoneManager;
+import org.apache.hadoop.ozone.om.SnapshotChainManager;
+import org.apache.hadoop.ozone.om.helpers.OmBucketInfo;
+import org.apache.hadoop.ozone.om.helpers.OmKeyInfo;
+import org.apache.hadoop.ozone.om.helpers.SnapshotInfo;
+import org.apache.hadoop.ozone.om.lock.IOzoneManagerLock;
+import org.apache.hadoop.ozone.om.snapshot.ReferenceCounted;
+import org.apache.ratis.util.MemoizedCheckedSupplier;
+import org.apache.ratis.util.function.CheckedSupplier;
+
+/**
+ * Filter to return deleted keys which are reclaimable based on their presence
in previous snapshot in
+ * the snapshot chain.
+ */
+public class ReclaimableKeyFilter extends ReclaimableFilter<OmKeyInfo> {
+ private final Map<UUID, Long> exclusiveSizeMap;
+ private final Map<UUID, Long> exclusiveReplicatedSizeMap;
+
+ /**
+ * @param currentSnapshotInfo : If null the deleted keys in AOS needs to be
processed, hence the latest snapshot
+ * in the snapshot chain corresponding to bucket
key needs to be processed.
+ * @param keyManager : keyManager corresponding to snapshot or AOS.
+ * @param lock : Lock for Active OM.
+ */
+ public ReclaimableKeyFilter(OzoneManager ozoneManager,
+ OmSnapshotManager omSnapshotManager,
SnapshotChainManager snapshotChainManager,
+ SnapshotInfo currentSnapshotInfo, KeyManager
keyManager,
+ IOzoneManagerLock lock) {
+ super(ozoneManager, omSnapshotManager, snapshotChainManager,
currentSnapshotInfo, keyManager, lock, 2);
+ this.exclusiveSizeMap = new HashMap<>();
+ this.exclusiveReplicatedSizeMap = new HashMap<>();
+ }
+
+ @Override
+ protected String getVolumeName(Table.KeyValue<String, OmKeyInfo> keyValue)
throws IOException {
+ return keyValue.getValue().getVolumeName();
+ }
+
+ @Override
+ protected String getBucketName(Table.KeyValue<String, OmKeyInfo> keyValue)
throws IOException {
+ return keyValue.getValue().getBucketName();
+ }
+
+ @Override
+ protected Boolean isReclaimable(Table.KeyValue<String, OmKeyInfo>
deletedKeyInfo) throws IOException {
+ ReferenceCounted<OmSnapshot> previousSnapshot = getPreviousOmSnapshot(1);
+
+
+ KeyManager previousKeyManager = Optional.ofNullable(previousSnapshot)
+ .map(i -> i.get().getKeyManager()).orElse(null);
+
+
+ // Getting keyInfo from prev snapshot's keyTable/fileTable
+ CheckedSupplier<Optional<OmKeyInfo>, IOException> previousKeyInfo =
+ MemoizedCheckedSupplier.valueOf(() ->
getPreviousSnapshotKey(getVolumeId(), getBucketInfo(),
+ deletedKeyInfo.getValue(), getKeyManager(), previousKeyManager));
+ // If file not present in previous snapshot then it won't be present in
previous to previous snapshot either.
+ if (!previousKeyInfo.get().isPresent()) {
+ return true;
+ }
+
+ ReferenceCounted<OmSnapshot> previousToPreviousSnapshot =
getPreviousOmSnapshot(0);
+ KeyManager previousToPreviousKeyManager =
Optional.ofNullable(previousToPreviousSnapshot)
+ .map(i -> i.get().getKeyManager()).orElse(null);
+
+ // Getting keyInfo from prev to prev snapshot's keyTable/fileTable based
on keyInfo of prev keyTable
+ CheckedSupplier<Optional<OmKeyInfo>, IOException> previousPrevKeyInfo =
+ MemoizedCheckedSupplier.valueOf(() -> getPreviousSnapshotKey(
+ getVolumeId(), getBucketInfo(),
previousKeyInfo.get().orElse(null), previousKeyManager,
+ previousToPreviousKeyManager));
+ SnapshotInfo previousSnapshotInfo = getPreviousSnapshotInfo(1);
+ calculateExclusiveSize(previousSnapshotInfo, previousKeyInfo,
previousPrevKeyInfo,
+ exclusiveSizeMap, exclusiveReplicatedSizeMap);
+ return false;
+ }
+
+ public Map<UUID, Long> getExclusiveSizeMap() {
+ return exclusiveSizeMap;
+ }
+
+ public Map<UUID, Long> getExclusiveReplicatedSizeMap() {
+ return exclusiveReplicatedSizeMap;
+ }
+
+ /**
+ * To calculate Exclusive Size for current snapshot, Check
+ * the next snapshot deletedTable if the deleted key is
+ * referenced in current snapshot and not referenced in the
+ * previous snapshot then that key is exclusive to the current
+ * snapshot. Here since we are only iterating through
+ * deletedTable we can check the previous and previous to
+ * previous snapshot to achieve the same.
+ * previousSnapshot - Snapshot for which exclusive size is
+ * getting calculating.
+ * currSnapshot - Snapshot's deletedTable is used to calculate
+ * previousSnapshot snapshot's exclusive size.
+ * previousToPrevSnapshot - Snapshot which is used to check
+ * if key is exclusive to previousSnapshot.
+ */
+ private void calculateExclusiveSize(SnapshotInfo previousSnapshotInfo,
Review Comment:
does this fix the exclusive size bug? related:
[HDDS-10051](https://issues.apache.org/jira/browse/HDDS-10051)
https://issues.apache.org/jira/browse/HDDS-11528
https://issues.apache.org/jira/browse/HDDS-11151
https://issues.apache.org/jira/browse/HDDS-9431
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
