nandakumar131 commented on code in PR #8420:
URL: https://github.com/apache/ozone/pull/8420#discussion_r2083251459
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/protocol/commands/CommandForDatanode.java:
##########
@@ -28,22 +29,26 @@
public class CommandForDatanode<T extends Message> implements
IdentifiableEventPayload {
- private final UUID datanodeId;
-
+ private final DatanodeID datanodeId;
private final SCMCommand<T> command;
public CommandForDatanode(DatanodeDetails datanode, SCMCommand<T> command) {
- this(datanode.getUuid(), command);
+ this(datanode.getID(), command);
}
// TODO: Command for datanode should take DatanodeDetails as parameter.
public CommandForDatanode(UUID datanodeId, SCMCommand<T> command) {
+ this(DatanodeID.of(datanodeId), command);
+ }
Review Comment:
Thanks @szetszwo for the review.
Addressed the review comment.
I wanted to keep the change small to make it easy for review. 🙂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org
