fapifta commented on pull request #2083: URL: https://github.com/apache/ozone/pull/2083#issuecomment-822637478
Hi @guihecheng, thank you for working on this, it seems to be a good improvement, I did throw the idea when working on the first implementation, as we thought about finalization as a not-too-long process, which will be monitored by an admin, but I can see the usefulness of this or the ease of understanding from the user's point of view compared to takeover. I think there is a critical flaw remained in the implementation, I have added a detailed comment about it inline. Besides that the changes looking good, however I have a linguistic suggestion, in the JIRA you have also mentione finalization-status, in the code we use finalizeStatus. I would go with finalizationStatus as the term on the CLI, and in the code as well, as we use the word finalization in other parts of the code. If you are up to changing this, I would be glad, though this is probably just a preference on my side. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
