avijayanhwx commented on a change in pull request #2142:
URL: https://github.com/apache/ozone/pull/2142#discussion_r616061599
##########
File path:
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/node/TestSCMNodeManager.java
##########
@@ -113,6 +117,18 @@
private File testDir;
private StorageContainerManager scm;
+ private static final int MAX_LV =
HDDSLayoutVersionManager.maxLayoutVersion();
+ private static final LayoutVersionProto LARGER_SLV_LAYOUT_PROTO =
+ toLayoutVersionProto(MAX_LV, MAX_LV + 1);
+ private static final LayoutVersionProto SMALLER_SLV_LAYOUT_PROTO =
+ toLayoutVersionProto(MAX_LV, MAX_LV - 1);
Review comment:
nit. Just to keep things theoretically correct, can we also set the
metadata version to MAX_LV - 1. (Since MLV cannot be > SLV)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
