ChenSammi commented on code in PR #8475:
URL: https://github.com/apache/ozone/pull/8475#discussion_r2095520400


##########
hadoop-hdds/framework/pom.xml:
##########
@@ -334,6 +334,20 @@
 
   <build>
     <plugins>
+      <plugin>
+        <groupId>com.coderplus.maven.plugins</groupId>
+        <artifactId>copy-rename-maven-plugin</artifactId>
+        <executions>
+          <execution>
+            <id>rename-generated-config</id>
+            <phase>process-classes</phase>
+          </execution>
+          <execution>
+            <id>rename-generated-test-config</id>
+            <phase>process-test-classes</phase>

Review Comment:
   For the two modules, famework  and common, who has this extra 
"process-test-classes", will both the two generated xml files be loaded during 
OzoneConfiguration activation? 
   If only first generated xml file will be loaded, how 
TestGeneratedConfigurationOverwrite.java can pass? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to