errose28 commented on PR #7490: URL: https://github.com/apache/ozone/pull/7490#issuecomment-2892383572
> We shouldn't allow reconciliation of a container that is already reconciling. This can lead to some other bugs where we update the metadata or the data in parallel. Most of this should be handled for us by the [ReplicationSupervisor](https://github.com/apache/ozone/blob/1aef378d70f11ed7523c397903b3a26edf93c635/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/replication/ReplicationSupervisor.java#L98) and tested generally [here](https://github.com/apache/ozone/blob/2b4708b70e5c9de133381a38ca7fa4b3cf3caa42/hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/replication/TestReplicationSupervisor.java#L558). However this depends on how we define the [uniqueness of the reconciliation commands](https://github.com/apache/ozone/blob/989746a0de358267be31ce81824046766b49bb7c/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/protocol/commands/ReconcileContainerCommand.java#L98) and here I think we do have a problem as you mentioned, because we can get multiple simultaneous reconciliation tasks for the same container if the peer list is different. We should fix this in a follow-up so that `ReconcileContainerCommand` equality is based only on container ID, and add a test for this that is unique to reconciliation commands. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For additional commands, e-mail: issues-h...@ozone.apache.org
