siddhantsangwan commented on PR #8491: URL: https://github.com/apache/ozone/pull/8491#issuecomment-2901051049
> @siddhantsangwan thanks for the review, I have made the changes and added a test, For the test added, I checked without the changes made in this patch, it fails (hence verifying that the expiration time was set in the past). Run of the failure without changes: https://github.com/Tejaskriya/ozone/actions/runs/15156730084/job/42613790646 Unfortunately this test is just failing because of: ``` moveManager.setMoveTimeout(Duration.ofMinutes(50).toMillis()); ``` It's not really testing what we want. In general it's a good practice to use the master branch for testing the 'before' version of the code so that unintended changes don't sneak in. This test currently passes on the master branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
