elek commented on pull request #2132:
URL: https://github.com/apache/ozone/pull/2132#issuecomment-823194254
> I think the release is far away
I am not sure. 1.1.0 is merged a long time ago, so it seems to be reasonable
to publish sg. in the next 1-2 months. (IMHO).
> The motivation for this is in Cloudera CM integration we don't need this
additional config for CM integration of SCM HA.
I have a very mixed feeling about this motivation. If it's a problem on the
vendor side, I strongly recommend fixing it on the vendor side instead of
Apache master. Especially if it can be done easily. There are other users of
Apache Ozone and I know at least one who uses snapshots from the master branch.
I think master should be as stable and secure as possible. This is the reason
why we use feature branches to stabilize all the works outside the master.
> HDDS-5060 is required only if log purging is enabled for SCM HA which is
currently disabled by default.
This is a very good argument, and I am fine with that if this is the case.
Can you please share how is this log purging used? Isn't it required for
bootstrapping/restoring Ratis nodes? Is this grpc endpoint turned off by
default? How is ratis snapshot moved between nodes when this is turned off?
> I prefer to merge this change right away.
My preference is keeping master always as secure and stable as possible. Our
1.1.0 release was delayed with 3-4 months because earlier we used snapshot
dependencies from Ratis. While I think it was a good decision earlier, my
preference is improving our practice and keeping the master always releasable.
(feature flags are good, but we should make it impossible to start something
which is supposed to be secure but not).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
