bharatviswa504 commented on a change in pull request #2108:
URL: https://github.com/apache/ozone/pull/2108#discussion_r616690502
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/s3/multipart/S3MultipartUploadCompleteRequest.java
##########
@@ -285,7 +285,7 @@ public OMClientResponse validateAndUpdateCache(OzoneManager
ozoneManager,
// But now as versioning is not supported, just following the commit
// key approach. When versioning support comes, then we can uncomment
// below code keyInfo.addNewVersion(locations);
- omKeyInfo.updateLocationInfoList(partLocationInfos, true);
+ omKeyInfo.updateLocationInfoList(partLocationInfos, true, true);
Review comment:
>The overwritten data will be leaked and not garbage collected properly.
It is already taken care in S3MultipartUploadCommitRequest and
S3MultipartUploadCommitPartResponse.
The over-ride part is moved to delete Table.
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/s3/multipart/S3MultipartUploadCompleteRequest.java
##########
@@ -285,7 +285,7 @@ public OMClientResponse validateAndUpdateCache(OzoneManager
ozoneManager,
// But now as versioning is not supported, just following the commit
// key approach. When versioning support comes, then we can uncomment
// below code keyInfo.addNewVersion(locations);
- omKeyInfo.updateLocationInfoList(partLocationInfos, true);
+ omKeyInfo.updateLocationInfoList(partLocationInfos, true, true);
Review comment:
>The overwritten data will be leaked and not garbage collected properly.
It is already taken care in S3MultipartUploadCommitRequest and
S3MultipartUploadCommitPartResponse.
The over-ride part is moved to delete Table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
