ChenSammi commented on code in PR #8488:
URL: https://github.com/apache/ozone/pull/8488#discussion_r2111270961
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/DatanodeStateMachine.java:
##########
@@ -704,6 +710,41 @@ private Thread getCommandHandlerThread(Runnable
processCommandQueue) {
return handlerThread;
}
+ /**
+ * Stops the DiskBalancerService if it is running.
+ */
+ public void stopDiskBalancer() {
Review Comment:
@Gargi-jais11, please move these diskBalancer related operations into
DiskBalancerService. For every service, we should put all it's handling
functions into the same class as much as possible. That's one thumb rule of
object orientated programming.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org
