ChenSammi commented on code in PR #8492:
URL: https://github.com/apache/ozone/pull/8492#discussion_r2115152789
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/impl/HddsDispatcher.java:
##########
@@ -335,7 +343,15 @@ && getMissingContainerSet().contains(containerID)) {
// Small performance optimization. We check if the operation is of type
// write before trying to send CloseContainerAction.
if (!HddsUtils.isReadOnly(msg)) {
- sendCloseContainerActionIfNeeded(container);
+ boolean isFull = isVolumeFull(container);
+ sendCloseContainerActionIfNeeded(container, isFull);
+ if (isFull) {
+ try {
+ handleFullVolume(container.getContainerData().getVolume());
+ } catch (StorageContainerException e) {
+ ContainerUtils.logAndReturnError(LOG, e, msg);
Review Comment:
It's OK not return here, but instead of calling
ContainerUtils.logAndReturnError, you can probably just log the failure
message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org
