swamirishi commented on PR #8503: URL: https://github.com/apache/ozone/pull/8503#issuecomment-2928216372
> > @yuxian0908 Instead of having to maintain 2 codecs can we just drop the entire snapdiff db as part of the upgrade framework. I just feel it would reduce a lot of complexity. Since snapshot diff db is an ephemeral db anyhow as all entries would be eventually deleted. > > @swamirishi Thanks for the input. In my opinion, this needs to be discussed and handled in a follow up ticket. Simply handling both the old and new codec should make things transparent to users without the need to carry out more operations like dropping the snapdiff db with upgrade framework (which requires some OM downtime due to current non-rolling upgrade framework). If we decide to do it in the upgrade framework, then we can remove the old codec entirely. How about we introduce a version file inside the snapdiff.db directory and read it [here](https://github.com/apache/ozone/blob/006e691245d98e65b712cf82b8ad4f199b673431/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmSnapshotManager.java#L226-L243) if the version number is different then we can just drop the db. It would be cleaner this way and we can get rid of the earlier implementation altogether. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For additional commands, e-mail: issues-h...@ozone.apache.org
