[
https://issues.apache.org/jira/browse/HDDS-8420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Siyao Meng resolved HDDS-8420.
------------------------------
Resolution: Won't Do
Thanks [~peterxcli] for checking this one out.
IIRC the idea of this jira is more of an (optional) optimization, which aims to
reduce the number of open snapshot checkpoint DBs in the cache when a leader
node transitions into a follower. Thus the lower priority. It is true that once
HDDS-6856 is done, this wouldn't be as useful. Let me close this one.
> [Snapshot] Optionally purge SnapshotCache on OM (ex)leader when it
> transitions to a follower
> --------------------------------------------------------------------------------------------
>
> Key: HDDS-8420
> URL: https://issues.apache.org/jira/browse/HDDS-8420
> Project: Apache Ozone
> Issue Type: Sub-task
> Reporter: Siyao Meng
> Assignee: Chu Cheng Li
> Priority: Minor
>
> SnapshotCache can be cleaned up when OM leader transitions to a follower. But
> not by simply calling {{snapshotCache.invalidateAll()}}.
> Cache entries with zero refCount can be safely invalidated. However, it could
> happen that some instances are still in-use by:
> 1. running SnapshotDiff jobs that is not finished during leader to follower
> transition -- those jobs need to be cancelled/aborted
> 2. any unfinished client read or write requests against snapshots issued
> before the leader OM to follower OM transition
> 3. new Ratis requests reading or writing to snapshot DB, including
> {{OMSnapshotMoveDeletedKeysRequest}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
