rakeshadr commented on pull request #2151:
URL: https://github.com/apache/ozone/pull/2151#issuecomment-823912809


   > > Instead of failing with an error, presently OM proceeds silently with 
default metadata layout by making isBucketFSOptimized flag to false.
   > 
   > It might be better to throw an exception in case of misconfiguration. the 
`isBucketFSOptimized` can be false when I configure PREFIX + fs.enabled = 
false, but the wrong metadata was saved to the key:
   > 
   > ```
   > bash-4.2$ ozone sh bucket info /vol1/bucket1     
   > {
   >   "metadata" : {
   >     "ozone.om.metadata.layout" : "PREFIX",
   >     "ozone.om.enable.filesystem.paths" : "false
   > ```
   > 
   > Even better: it would be great to use just the `ozone.om.metadata.layout` 
and always turn on `ozone.om.enable.filesystem.paths` implicitly as it seems to 
be a strong requirement.
   
   Thanks @elek for the clear information, IMHO to throw exception in case of 
invalid configuration and fail OM startup. I've updated the PR with this 
behavior.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to