ChenSammi commented on code in PR #8512: URL: https://github.com/apache/ozone/pull/8512#discussion_r2131441366
########## hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/diskbalancer/policy/DefaultContainerChoosingPolicy.java: ########## @@ -33,18 +38,33 @@ public class DefaultContainerChoosingPolicy implements ContainerChoosingPolicy { public static final Logger LOG = LoggerFactory.getLogger( DefaultContainerChoosingPolicy.class); + private final ThreadLocal<Cache<HddsVolume, Iterator<Container<?>>>> containerIteratorCache = Review Comment: Can we get any benefit by change it to static? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For additional commands, e-mail: issues-h...@ozone.apache.org