elek commented on a change in pull request #2052:
URL: https://github.com/apache/ozone/pull/2052#discussion_r617434787



##########
File path: hadoop-ozone/dist/src/main/compose/ozonesecure/test.sh
##########
@@ -27,39 +27,42 @@ export SECURITY_ENABLED=true
 
 : ${OZONE_BUCKET_KEY_NAME:=key1}
 
-start_docker_env
+for enable in true false; do

Review comment:
       Thanks to explain it @bharatviswa504. I think it's too expensive to run 
ALL the tests in two modes. For example, we can assume that the linked and real 
buckets working at the same way as they already tested. We don't need to test 
all of them in both cases (IMHO).
   
   I think it's fine to test different settings to make sure if it works. But 
we can adjust the required tests. For the main/default case we can execute all 
the tests and the other mode we can execute only a minimum set. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to