Copilot commented on code in PR #8589:
URL: https://github.com/apache/ozone/pull/8589#discussion_r2135162467
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/impl/ContainerSet.java:
##########
@@ -66,22 +67,23 @@ public class ContainerSet implements Iterable<Container<?>>
{
new ConcurrentSkipListMap<>();
private final Clock clock;
private long recoveringTimeout;
- private final Table<ContainerID, String> containerIdsTable;
+ private final Table<ContainerID, ContainerCreateInfo> containerIdsTable;
public static ContainerSet newReadOnlyContainerSet(long recoveringTimeout) {
return new ContainerSet(null, recoveringTimeout);
}
- public static ContainerSet newRwContainerSet(Table<ContainerID, String>
containerIdsTable, long recoveringTimeout) {
+ public static ContainerSet newRwContainerSet(
+ Table<ContainerID, ContainerCreateInfo> containerIdsTable, long
recoveringTimeout) {
Objects.requireNonNull(containerIdsTable, "containerIdsTable == null");
return new ContainerSet(containerIdsTable, recoveringTimeout);
}
- private ContainerSet(Table<ContainerID, String> continerIdsTable, long
recoveringTimeout) {
+ private ContainerSet(Table<ContainerID, ContainerCreateInfo>
continerIdsTable, long recoveringTimeout) {
this(continerIdsTable, recoveringTimeout, null);
}
- ContainerSet(Table<ContainerID, String> continerIdsTable, long
recoveringTimeout, Clock clock) {
+ ContainerSet(Table<ContainerID, ContainerCreateInfo> continerIdsTable, long
recoveringTimeout, Clock clock) {
this.clock = clock != null ? clock : Clock.systemUTC();
this.containerIdsTable = continerIdsTable;
Review Comment:
The parameter name 'continerIdsTable' is misspelled; it should be
'containerIdsTable' for consistency with field names.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
