sumitagrawl commented on code in PR #8003:
URL: https://github.com/apache/ozone/pull/8003#discussion_r2135559751
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java:
##########
@@ -5159,6 +5161,12 @@ private String
reconfOzoneDirDeletingServiceInterval(String newVal) {
return newVal;
}
+ private String reconfOzoneThreadNumberDirDeletion(String newVal) {
+ getConfiguration().set(OZONE_THREAD_NUMBER_DIR_DELETION, newVal);
Review Comment:
restart trigger should be done now on 2 param matches, interval,
threadCount, but this new addition is not there in registered callback at
DirectoryDeletingService
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/impl/BlockDeletingService.java:
##########
@@ -94,12 +98,31 @@ public BlockDeletingService(
dnConf = conf.getObject(DatanodeConfiguration.class);
if (reconfigurationHandler != null) {
reconfigurationHandler.register(dnConf);
+ registerReconfigCallbacks(reconfigurationHandler, (OzoneConfiguration)
conf);
}
this.blockDeletingMaxLockHoldingTime =
dnConf.getBlockDeletingMaxLockHoldingTime();
metrics = BlockDeletingServiceMetrics.create();
}
+ public void registerReconfigCallbacks(ReconfigurationHandler handler,
OzoneConfiguration ozoneConf) {
+ handler.registerCompleteCallback((changedKeys, newConf) -> {
+ if (changedKeys.containsKey(OZONE_BLOCK_DELETING_SERVICE_INTERVAL)) {
Review Comment:
For timeout also, do need restart the service? it is directly set in
HddsDatanodeService, do that setting needs to be done here during
updateAndRestart ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
