siddhantsangwan commented on code in PR #8573: URL: https://github.com/apache/ozone/pull/8573#discussion_r2135620188
########## hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/volume/HddsVolume.java: ########## @@ -346,6 +349,33 @@ public VolumeCheckResult checkDbHealth(File dbFile) throws InterruptedException return VolumeCheckResult.HEALTHY; } + @VisibleForTesting + public void checkVolumeUsages() { + boolean isEnoughSpaceAvailable = true; + SpaceUsageSource currentUsage = getCurrentUsage(); + long getFreeSpaceToSpare = getFreeSpaceToSpare(currentUsage.getCapacity()); + if (currentUsage.getAvailable() < getFreeSpaceToSpare) { + LOG.warn("Volume {} has insufficient space for write operation. Available: {}, Free space to spare: {}", + getStorageDir(), currentUsage.getAvailable(), getFreeSpaceToSpare); + isEnoughSpaceAvailable = false; Review Comment: https://github.com/apache/ozone/pull/8590 is introducing an `isVolumeFull` method to check this. We can use that method once that pr is merged. Can make the change in the current pr or a future pr for refactoring. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For additional commands, e-mail: issues-h...@ozone.apache.org