jojochuang commented on code in PR #8547:
URL: https://github.com/apache/ozone/pull/8547#discussion_r2136879622
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/service/DirectoryDeletingService.java:
##########
@@ -140,18 +149,20 @@ public class DirectoryDeletingService extends
AbstractKeyDeletingService {
// from parent directory info from deleted directory table concurrently
// and send deletion requests.
private int ratisByteLimit;
- private final AtomicBoolean suspended;
private final AtomicBoolean isRunningOnAOS;
private final SnapshotChainManager snapshotChainManager;
private final boolean deepCleanSnapshots;
private final ExecutorService deletionThreadPool;
private final int numberOfParallelThreadsPerStore;
+ private final AtomicLong deletedDirsCount;
+ private final AtomicLong movedDirsCount;
+ private final AtomicLong movedFilesCount;
public DirectoryDeletingService(long interval, TimeUnit unit,
long serviceTimeout, OzoneManager ozoneManager,
OzoneConfiguration configuration, int dirDeletingServiceCorePoolSize,
boolean deepCleanSnapshots) {
super(DirectoryDeletingService.class.getSimpleName(), interval, unit,
- dirDeletingServiceCorePoolSize, serviceTimeout, ozoneManager, null);
+ dirDeletingServiceCorePoolSize, serviceTimeout, ozoneManager);
Review Comment:
would dirDeletingServiceCorePoolSize needs to be larger than 10 if number of
snapshots is big? should we pick a larger default value
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
