peterxcli commented on code in PR #8610:
URL: https://github.com/apache/ozone/pull/8610#discussion_r2142352760
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/DiskBalancerManager.java:
##########
@@ -107,7 +108,20 @@ public List<HddsProtos.DatanodeDiskBalancerInfoProto>
getDiskBalancerStatus(
List<DatanodeDetails> filterDns = null;
if (hosts.isPresent() && !hosts.get().isEmpty()) {
filterDns = NodeUtils.mapHostnamesToDatanodes(nodeManager, hosts.get(),
- useHostnames);
+ useHostnames).stream()
+ .filter(dn -> {
+ try {
+ if (nodeManager.getNodeStatus(dn) !=
NodeStatus.inServiceHealthy()) {
+ LOG.warn("Datanode {} is not in optimal state for disk
balancing." +
+ " Operational state: {}", dn.getHostName(),
nodeManager.getNodeStatus(dn).getOperationalState());
Review Comment:
I'm not sure this log is needed? If yes, please change to:
```suggestion
.filter(dn -> {
try {
NodeStatus nodeStatus = nodeManager.getNodeStatus(dn);
if (nodeStatus != NodeStatus.inServiceHealthy()) {
LOG.warn("Datanode {} is not in optimal state for disk
balancing." +
" Operational state: {}", dn.getHostName(),
nodeStatus.getOperationalState());
```
otherwise it would query the nodeStatusMap twice
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
