szetszwo commented on code in PR #8607:
URL: https://github.com/apache/ozone/pull/8607#discussion_r2143329916
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/service/QuotaRepairTask.java:
##########
@@ -399,22 +399,18 @@ private static <VALUE> void extractCount(
Table.KeyValue<String, VALUE> kv,
Map<String, CountPair> prefixUsageMap,
boolean haveValue) {
- try {
- String prefix = getVolumeBucketPrefix(kv.getKey());
- CountPair usage = prefixUsageMap.get(prefix);
- if (null == usage) {
- return;
- }
- usage.incrNamespace(1L);
- // avoid decode of value
- if (haveValue) {
- VALUE value = kv.getValue();
- if (value instanceof OmKeyInfo) {
- usage.incrSpace(((OmKeyInfo) value).getReplicatedSize());
- }
+ String prefix = getVolumeBucketPrefix(kv.getKey());
+ CountPair usage = prefixUsageMap.get(prefix);
+ if (null == usage) {
+ return;
+ }
+ usage.incrNamespace(1L);
+ // avoid decode of value
Review Comment:
It seems never working since `OmKeyInfo`/`OmDirectoryInfo` supported
CodecBuffer -- it was always decoded. Cc @sumitagrawl
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
