Gargi-jais11 commented on code in PR #8610:
URL: https://github.com/apache/ozone/pull/8610#discussion_r2144354204
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/DiskBalancerManager.java:
##########
@@ -107,7 +108,21 @@ public List<HddsProtos.DatanodeDiskBalancerInfoProto>
getDiskBalancerStatus(
List<DatanodeDetails> filterDns = null;
if (hosts.isPresent() && !hosts.get().isEmpty()) {
filterDns = NodeUtils.mapHostnamesToDatanodes(nodeManager, hosts.get(),
- useHostnames);
+ useHostnames).stream()
+ .filter(dn -> {
+ try {
+ NodeStatus nodeStatus = nodeManager.getNodeStatus(dn);
+ if (nodeStatus != NodeStatus.inServiceHealthy()) {
+ LOG.warn("Datanode {} is not in optimal state for disk
balancing." +
+ " Operational state: {}", dn.getHostName(),
nodeStatus.getOperationalState());
Review Comment:
I was working for updating unit test but found that even on setting
nodestate below as this
`nodeManager.setNodeOperationalState(dn0,
HddsProtos.NodeOperationalState.DECOMMISSIONED);`
It is still returning nodestatus as IN_SERVICE that's due to
`MockNodeManager#getNodeStatus()`, it is always returning in-service. I tried
in many way but not found anything to change dn state and persist it.
It is better to update integration test for diskBalancer Status.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
