szetszwo commented on code in PR #8644:
URL: https://github.com/apache/ozone/pull/8644#discussion_r2153308528
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/impl/KeyValueStreamDataChannel.java:
##########
@@ -59,6 +59,7 @@ public int write(ReferenceCountedObject<ByteBuffer>
referenceCounted)
throws IOException {
getMetrics().incContainerOpsMetrics(getType());
assertOpen();
+ assertSpaceAvailability();
Review Comment:
It should account for `referenceCounted.get().remaining()`.
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/impl/StreamDataChannelBase.java:
##########
@@ -93,6 +94,14 @@ public final boolean isOpen() {
return getChannel().isOpen();
}
+ protected void assertSpaceAvailability() throws IOException {
+ if (containerData.getVolume().isVolumeFull()) {
+ throw new StorageContainerException("write failed for container " +
containerData.getContainerID()
+ + " due to volume " + containerData.getVolume().getStorageID() + "
out of space "
+ + containerData.getVolume().getCurrentUsage(), DISK_OUT_OF_SPACE);
Review Comment:
We should print also the reserved space and the required space; otherwise,
the message will be confusing since it will show space available.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
