devabhishekpal commented on code in PR #8568:
URL: https://github.com/apache/ozone/pull/8568#discussion_r2161047413
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/OMDBInsightEndpoint.java:
##########
@@ -635,17 +636,21 @@ private void getPendingForDeletionDirInfo(
* @return total used data size in bytes
* @throws IOException ioEx
*/
- protected long fetchSizeForDeletedDirectory(long objectId)
+ protected Pair<Long, Long> fetchSizeForDeletedDirectory(long objectId)
Review Comment:
It would be good to update the javadoc for this method.
Currently it says return total data size (no replication)
It should be changed to:
```
/**
* Given an object ID, return total data size as a pair of Total Size,
Total Replicated Size
* under this object. Note:- This method is RECURSIVE.
*
* @param objectId the object's ID
* @return total used data size and replicated total used data size in
bytes
* @throws IOException ioEx
*/
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
