adoroszlai commented on code in PR #47:
URL:
https://github.com/apache/ozone-docker-runner/pull/47#discussion_r2162462411
##########
Dockerfile:
##########
@@ -96,8 +96,20 @@ RUN set -eux ; \
mv dumb-init /usr/local/bin/dumb-init
#byteman test for development
-RUN curl -Lo /opt/byteman.jar
https://repo.maven.apache.org/maven2/org/jboss/byteman/byteman/4.0.23/byteman-4.0.23.jar
\
- && chmod o+r /opt/byteman.jar
+ARG BYTEMAN_VERSION=4.0.25
+ARG BYTEMAN_HOME=/opt/byteman/
Review Comment:
```suggestion
ARG BYTEMAN_HOME=/opt/byteman
```
##########
Dockerfile:
##########
@@ -96,8 +96,20 @@ RUN set -eux ; \
mv dumb-init /usr/local/bin/dumb-init
#byteman test for development
-RUN curl -Lo /opt/byteman.jar
https://repo.maven.apache.org/maven2/org/jboss/byteman/byteman/4.0.23/byteman-4.0.23.jar
\
- && chmod o+r /opt/byteman.jar
+ARG BYTEMAN_VERSION=4.0.25
+ARG BYTEMAN_HOME=/opt/byteman/
+RUN sudo yum install unzip -y && \
+ curl -L -o /tmp/byteman.zip \
+
https://downloads.jboss.org/byteman/${BYTEMAN_VERSION}/byteman-download-${BYTEMAN_VERSION}-bin.zip
&& \
Review Comment:
nit: indent line continuation, or put on one line
##########
Dockerfile:
##########
@@ -96,8 +96,20 @@ RUN set -eux ; \
mv dumb-init /usr/local/bin/dumb-init
#byteman test for development
-RUN curl -Lo /opt/byteman.jar
https://repo.maven.apache.org/maven2/org/jboss/byteman/byteman/4.0.23/byteman-4.0.23.jar
\
- && chmod o+r /opt/byteman.jar
+ARG BYTEMAN_VERSION=4.0.25
+ARG BYTEMAN_HOME=/opt/byteman/
+RUN sudo yum install unzip -y && \
Review Comment:
Please add `unzip` package in existing install command:
https://github.com/apache/ozone-docker-runner/blob/d2fd9a2d59126546a521fa52a739c918eb125ee8/Dockerfile#L53-L54
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
