elek opened a new pull request #2177:
URL: https://github.com/apache/ozone/pull/2177


   ## What changes were proposed in this pull request?
   
   `hadoop-ozone/dist/src/main/license/bin/LICENSE.txt` and 
`hadoop-ozone/dist/src/main/license/bin/LICENSE.txt` should be modified when 
the transitive dependencies are changed.
   
   However, it's very easy to miss any dependency change when we bump versions. 
It's possible that we change only versions but we also introduce new jar files 
via transitive dependencies.
   
   This happened (for example) in #2139 and #2065 
   
   To avoid any mistake I suggest the same approach what we use the protobuf 
compatibility check:
   
   1. commit the current list of the jar files to the repository
   2. create a check which compares the actual value with the committed one
   
   If new dependency is introduced, the LICENSE file can be updated and the 
committed jar list also can be updated.
   
   ## How was this patch tested?
   
   Tested on my fork. 
   
   Example of failing builds:
   
   https://github.com/elek/ozone/runs/2407951331?check_suite_focus=true


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to