myskov commented on code in PR #8704: URL: https://github.com/apache/ozone/pull/8704#discussion_r2177016556
########## hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/metrics/MutableQuantiles.java: ########## @@ -0,0 +1,168 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.ozone.metrics; + +import com.google.common.util.concurrent.ThreadFactoryBuilder; +import java.text.DecimalFormat; +import java.util.Map; +import java.util.concurrent.Executors; +import java.util.concurrent.ScheduledExecutorService; +import java.util.concurrent.ScheduledFuture; +import java.util.concurrent.TimeUnit; +import org.apache.commons.lang3.StringUtils; +import org.apache.hadoop.classification.VisibleForTesting; +import org.apache.hadoop.metrics2.MetricsInfo; +import org.apache.hadoop.metrics2.MetricsRecordBuilder; +import org.apache.hadoop.metrics2.lib.Interns; +import org.apache.hadoop.metrics2.lib.MutableMetric; +import org.apache.hadoop.metrics2.util.Quantile; +import org.apache.hadoop.metrics2.util.QuantileEstimator; +import org.apache.hadoop.metrics2.util.SampleQuantiles; +/** + * The class was added in order to use it later for non-blocking metrics as it was not possible + * to inherit from the existing ones. + * A version of {@link org.apache.hadoop.metrics2.lib.MutableQuantiles}. + */ +public class MutableQuantiles extends MutableMetric { + @VisibleForTesting + public static final Quantile[] QUANTILES = new Quantile[]{new Quantile((double)0.5F, 0.05), new Quantile((double)0.75F, 0.025), new Quantile(0.9, 0.01), new Quantile(0.95, 0.005), new Quantile(0.99, 0.001)}; Review Comment: Looks like broken formatting. @kostacie could you check, please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For additional commands, e-mail: issues-h...@ozone.apache.org
